Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/browser_focus_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index b67422e8813b4357dd4fb7e8d519562ef93ba8b7..fefd90041fe106bfbc94d09c529c8898261a7b29 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -186,18 +186,19 @@ WebContents* GetTabAndRevertIfNecessary(Browser* browser,
WindowOpenDisposition disposition) {
WebContents* current_tab = browser->tab_strip_model()->GetActiveWebContents();
switch (disposition) {
- case NEW_FOREGROUND_TAB:
- case NEW_BACKGROUND_TAB: {
+ case WindowOpenDisposition::NEW_FOREGROUND_TAB:
+ case WindowOpenDisposition::NEW_BACKGROUND_TAB: {
WebContents* new_tab = current_tab->Clone();
- if (disposition == NEW_BACKGROUND_TAB)
+ if (disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB)
new_tab->WasHidden();
browser->tab_strip_model()->AddWebContents(
new_tab, -1, ui::PAGE_TRANSITION_LINK,
- (disposition == NEW_FOREGROUND_TAB) ?
- TabStripModel::ADD_ACTIVE : TabStripModel::ADD_NONE);
+ (disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB)
+ ? TabStripModel::ADD_ACTIVE
+ : TabStripModel::ADD_NONE);
return new_tab;
}
- case NEW_WINDOW: {
+ case WindowOpenDisposition::NEW_WINDOW: {
WebContents* new_tab = current_tab->Clone();
Browser* new_browser =
new Browser(Browser::CreateParams(browser->profile()));
@@ -469,7 +470,8 @@ void Home(Browser* browser, WindowOpenDisposition disposition) {
url = extensions::AppLaunchInfo::GetLaunchWebURL(extension);
}
- if (disposition == CURRENT_TAB || disposition == NEW_FOREGROUND_TAB)
+ if (disposition == WindowOpenDisposition::CURRENT_TAB ||
+ disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB)
extensions::MaybeShowExtensionControlledHomeNotification(browser);
#endif
« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/browser_focus_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698