chrome/browser/ui/settings_window_manager.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/settings_window_manager.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/settings_window_manager.cc

diff --git a/chrome/browser/ui/settings_window_manager.cc b/chrome/browser/ui/settings_window_manager.cc

index 9a8d599289b83f4d7c83e3b527f1c155c770a3b8..0567638d8c81ef0b1f30cdb3c10e44ebda089186 100644

--- a/chrome/browser/ui/settings_window_manager.cc

+++ b/chrome/browser/ui/settings_window_manager.cc

@@ -60,7 +60,7 @@ void SettingsWindowManager::ShowChromePageForProfile(Profile* profile,

// No existing browser window, create one.

NavigateParams params(profile, gurl, ui::PAGE_TRANSITION_AUTO_BOOKMARK);

- params.disposition = NEW_POPUP;

+ params.disposition = WindowOpenDisposition::NEW_POPUP;

params.trusted_source = true;

params.window_action = NavigateParams::SHOW_WINDOW;

params.user_gesture = true;