Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7990)

Unified Diff: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/view_id_util_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm
index 55103fe0506225c6a7ad12113cc29a05a1ad80e0..b935b4c5493b0487cb3d2df21f20b644bd3f9445 100644
--- a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm
+++ b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm
@@ -115,21 +115,17 @@ IN_PROC_BROWSER_TEST_F(ViewIDTest, Tab) {
// Open 9 new tabs.
for (int i = 1; i <= 9; ++i) {
CheckViewID(static_cast<ViewID>(VIEW_ID_TAB_0 + i), false);
- browser()->OpenURL(OpenURLParams(GURL(url::kAboutBlankURL),
- Referrer(),
- NEW_BACKGROUND_TAB,
- ui::PAGE_TRANSITION_TYPED,
- false));
+ browser()->OpenURL(OpenURLParams(GURL(url::kAboutBlankURL), Referrer(),
+ WindowOpenDisposition::NEW_BACKGROUND_TAB,
+ ui::PAGE_TRANSITION_TYPED, false));
CheckViewID(static_cast<ViewID>(VIEW_ID_TAB_0 + i), true);
// VIEW_ID_TAB_LAST should always be available.
CheckViewID(VIEW_ID_TAB_LAST, true);
}
// Open the 11th tab.
- browser()->OpenURL(OpenURLParams(GURL(url::kAboutBlankURL),
- Referrer(),
- NEW_BACKGROUND_TAB,
- ui::PAGE_TRANSITION_TYPED,
- false));
+ browser()->OpenURL(OpenURLParams(GURL(url::kAboutBlankURL), Referrer(),
+ WindowOpenDisposition::NEW_BACKGROUND_TAB,
+ ui::PAGE_TRANSITION_TYPED, false));
CheckViewID(VIEW_ID_TAB_LAST, true);
}

Powered by Google App Engine
This is Rietveld 408576698