chrome/browser/extensions/extension_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_browsertest.cc

diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc

index b1eff5f588c42d1adbee8b24d3eb61e04475f2b6..4590b770a7c41ad0c19b9428475516770f2bb389 100644

--- a/chrome/browser/extensions/extension_browsertest.cc

+++ b/chrome/browser/extensions/extension_browsertest.cc

@@ -318,7 +318,8 @@ const Extension* ExtensionBrowserTest::LoadAndLaunchApp(

content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,

content::NotificationService::AllSources());

AppLaunchParams params(profile(), app, extensions::LAUNCH_CONTAINER_NONE,

- NEW_WINDOW, extensions::SOURCE_TEST);

+ WindowOpenDisposition::NEW_WINDOW,

+ extensions::SOURCE_TEST);

params.command_line = *base::CommandLine::ForCurrentProcess();

OpenApplication(params);

app_loaded_observer.Wait();