Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_host.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
index 6c9ff477ef1941b77eaf0e6bd5055c5e25675a97..c02aaceed03f4c72911c55a185f33cb21e62c482 100644
--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
@@ -168,14 +168,12 @@ WebContents* ExtensionOptionsGuest::OpenURLFromTab(
// this guest view, change the disposition to NEW_FOREGROUND_TAB.
if ((!params.url.SchemeIs(extensions::kExtensionScheme) ||
params.url.host() != options_page_.host()) &&
- params.disposition == CURRENT_TAB) {
+ params.disposition == WindowOpenDisposition::CURRENT_TAB) {
return extension_options_guest_delegate_->OpenURLInNewTab(
- content::OpenURLParams(params.url,
- params.referrer,
- params.frame_tree_node_id,
- NEW_FOREGROUND_TAB,
- params.transition,
- params.is_renderer_initiated));
+ content::OpenURLParams(
+ params.url, params.referrer, params.frame_tree_node_id,
+ WindowOpenDisposition::NEW_FOREGROUND_TAB, params.transition,
+ params.is_renderer_initiated));
}
return extension_options_guest_delegate_->OpenURLInNewTab(params);
}
@@ -213,11 +211,9 @@ bool ExtensionOptionsGuest::ShouldCreateWebContents(
// ctrl-click or middle mouse button click
if (extension_options_guest_delegate_) {
extension_options_guest_delegate_->OpenURLInNewTab(
- content::OpenURLParams(target_url,
- content::Referrer(),
- NEW_FOREGROUND_TAB,
- ui::PAGE_TRANSITION_LINK,
- false));
+ content::OpenURLParams(target_url, content::Referrer(),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui::PAGE_TRANSITION_LINK, false));
}
return false;
}
« no previous file with comments | « extensions/browser/extension_host.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698