chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_interactive_uitest.cc ('k') | chrome/browser/password_manager/account_chooser_dialog_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer_browsertest.cc

diff --git a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer_browsertest.cc b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer_browsertest.cc

index d920c178ca3c30a667a58802aaaa2735b2794439..87e1782cd18656161465276a84aa951741a74b41 100644

--- a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer_browsertest.cc

+++ b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer_browsertest.cc

@@ -80,7 +80,8 @@ class HttpsEngagementPageLoadMetricsBrowserTest : public InProcessBrowserTest {

base::TimeTicks start = base::TimeTicks::Now();

ui_test_utils::NavigateToURL(browser(), url);

ui_test_utils::NavigateToURLWithDisposition(

- browser(), GURL(chrome::kChromeUIVersionURL), NEW_FOREGROUND_TAB,

+ browser(), GURL(chrome::kChromeUIVersionURL),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

base::TimeDelta upper_bound_delta = base::TimeTicks::Now() - start;

@@ -103,7 +104,7 @@ class HttpsEngagementPageLoadMetricsBrowserTest : public InProcessBrowserTest {

void NavigateInBackgroundAndClose(GURL url) {

ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIVersionURL));

ui_test_utils::NavigateToURLWithDisposition(

- browser(), url, NEW_BACKGROUND_TAB,

+ browser(), url, WindowOpenDisposition::NEW_BACKGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

// Make sure the correct tab is in the foreground.

@@ -124,7 +125,7 @@ class HttpsEngagementPageLoadMetricsBrowserTest : public InProcessBrowserTest {

base::TimeDelta NavigateInBackgroundAndCloseInForegroundWithTiming(GURL url) {

ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIVersionURL));

ui_test_utils::NavigateToURLWithDisposition(

- browser(), url, NEW_BACKGROUND_TAB,

+ browser(), url, WindowOpenDisposition::NEW_BACKGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

// Make sure the correct tab is in the foreground.