chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

diff --git a/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc b/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

index 0c19abe7be9da3ffec477971198cba7696a02f3d..699c1a2b4251fa936ff06106962b10960c05b809 100644

--- a/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

+++ b/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

@@ -241,7 +241,7 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowPropertyManagerTest, DISABLED_HostedApp) {

OpenApplication(AppLaunchParams(

browser()->profile(), extension, extensions::LAUNCH_CONTAINER_WINDOW,

- NEW_FOREGROUND_TAB, extensions::SOURCE_TEST));

+ WindowOpenDisposition::NEW_FOREGROUND_TAB, extensions::SOURCE_TEST));

// Check that the new browser has an app name.

// The launch should have created a new browser.

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/frame/global_menu_bar_x11.cc » ('j') | no next file with comments »