Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h" 5 #include "chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 delegate_->WillExecuteCommand(id, selection_); 138 delegate_->WillExecuteCommand(id, selection_);
139 139
140 base::WeakPtr<BookmarkContextMenuController> ref(weak_factory_.GetWeakPtr()); 140 base::WeakPtr<BookmarkContextMenuController> ref(weak_factory_.GetWeakPtr());
141 141
142 switch (id) { 142 switch (id) {
143 case IDC_BOOKMARK_BAR_OPEN_ALL: 143 case IDC_BOOKMARK_BAR_OPEN_ALL:
144 case IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO: 144 case IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO:
145 case IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW: { 145 case IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW: {
146 WindowOpenDisposition initial_disposition; 146 WindowOpenDisposition initial_disposition;
147 if (id == IDC_BOOKMARK_BAR_OPEN_ALL) { 147 if (id == IDC_BOOKMARK_BAR_OPEN_ALL) {
148 initial_disposition = NEW_BACKGROUND_TAB; 148 initial_disposition = WindowOpenDisposition::NEW_BACKGROUND_TAB;
149 content::RecordAction( 149 content::RecordAction(
150 UserMetricsAction("BookmarkBar_ContextMenu_OpenAll")); 150 UserMetricsAction("BookmarkBar_ContextMenu_OpenAll"));
151 } else if (id == IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW) { 151 } else if (id == IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW) {
152 initial_disposition = NEW_WINDOW; 152 initial_disposition = WindowOpenDisposition::NEW_WINDOW;
153 content::RecordAction( 153 content::RecordAction(
154 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllInNewWindow")); 154 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllInNewWindow"));
155 } else { 155 } else {
156 initial_disposition = OFF_THE_RECORD; 156 initial_disposition = WindowOpenDisposition::OFF_THE_RECORD;
157 content::RecordAction( 157 content::RecordAction(
158 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllIncognito")); 158 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllIncognito"));
159 } 159 }
160 chrome::OpenAll(parent_window_, navigator_, selection_, 160 chrome::OpenAll(parent_window_, navigator_, selection_,
161 initial_disposition, profile_); 161 initial_disposition, profile_);
162 break; 162 break;
163 } 163 }
164 164
165 case IDC_BOOKMARK_BAR_RENAME_FOLDER: 165 case IDC_BOOKMARK_BAR_RENAME_FOLDER:
166 case IDC_BOOKMARK_BAR_EDIT: 166 case IDC_BOOKMARK_BAR_EDIT:
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 return !managed->managed_node()->empty(); 429 return !managed->managed_node()->empty();
430 } 430 }
431 431
432 return true; 432 return true;
433 } 433 }
434 434
435 void BookmarkContextMenuController::BookmarkModelChanged() { 435 void BookmarkContextMenuController::BookmarkModelChanged() {
436 if (delegate_) 436 if (delegate_)
437 delegate_->CloseMenu(); 437 delegate_->CloseMenu();
438 } 438 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698