chrome/browser/printing/print_preview_dialog_controller_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

diff --git a/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc b/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

index a9f65b3f9b5b064045ef35f525322d18fcb7f175..050ed53601429d920125ef416d0df8eae353a3b6 100644

--- a/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

+++ b/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

@@ -263,7 +263,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewDialogControllerBrowserTest,

// Reload the initiator. Make sure reloading destroys the print preview

// dialog.

PrintPreviewDialogDestroyedObserver dialog_destroyed_observer(preview_dialog);

- chrome::Reload(browser(), CURRENT_TAB);

+ chrome::Reload(browser(), WindowOpenDisposition::CURRENT_TAB);

content::WaitForLoadStop(

browser()->tab_strip_model()->GetActiveWebContents());

ASSERT_TRUE(dialog_destroyed_observer.dialog_destroyed());

« no previous file with comments | « chrome/browser/printing/print_dialog_cloud_win.cc ('k') | chrome/browser/profiles/host_zoom_map_browsertest.cc » ('j') | no next file with comments »