chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_bubble_model.cc ('k') | chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

diff --git a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

index ba517082270bd026e11bd2dc17aa2861d0567956..0165f04abc0c2a748d3cfb1715c5c8269b50aef6 100644

--- a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

+++ b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

@@ -377,9 +377,9 @@ BOOL forceMagicMouse = NO;

historyOverlay_.view.window);

if (browser) {

if (direction == history_swiper::kForwards)

- chrome::GoForward(browser, CURRENT_TAB);

+ chrome::GoForward(browser, WindowOpenDisposition::CURRENT_TAB);

else

- chrome::GoBack(browser, CURRENT_TAB);

+ chrome::GoBack(browser, WindowOpenDisposition::CURRENT_TAB);

}

@@ -482,9 +482,9 @@ BOOL forceMagicMouse = NO;

chrome::FindBrowserWithWindow(historyOverlay.view.window);

if (ended && browser) {

if (isRightScroll)

- chrome::GoForward(browser, CURRENT_TAB);

+ chrome::GoForward(browser, WindowOpenDisposition::CURRENT_TAB);

else

- chrome::GoBack(browser, CURRENT_TAB);

+ chrome::GoBack(browser, WindowOpenDisposition::CURRENT_TAB);

}

if (ended || isComplete) {