chrome/browser/ui/views/toolbar/reload_button.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/reload_button.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/reload_button.cc

diff --git a/chrome/browser/ui/views/toolbar/reload_button.cc b/chrome/browser/ui/views/toolbar/reload_button.cc

index 3f331c52860a6f3e48bbdc103ffea72c9c6cad24..6a73e53425d92f9b6687bb99114813e25b01b11e 100644

--- a/chrome/browser/ui/views/toolbar/reload_button.cc

+++ b/chrome/browser/ui/views/toolbar/reload_button.cc

@@ -139,7 +139,8 @@ void ReloadButton::ButtonPressed(views::Button* /* button */,

if (visible_mode_ == MODE_STOP) {

if (command_updater_)

- command_updater_->ExecuteCommandWithDisposition(IDC_STOP, CURRENT_TAB);

+ command_updater_->ExecuteCommandWithDisposition(

+ IDC_STOP, WindowOpenDisposition::CURRENT_TAB);

// The user has clicked, so we can feel free to update the button,

// even if the mouse is still hovering.

ChangeMode(MODE_RELOAD, true);