chrome/browser/extensions/window_open_apitest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/window_open_apitest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/window_open_apitest.cc

diff --git a/chrome/browser/extensions/window_open_apitest.cc b/chrome/browser/extensions/window_open_apitest.cc

index f7d9d92f2b8f26154cf682774ed21110521f6088..6608957f575d4ac860a9cda6237dc4f214f24cd8 100644

--- a/chrome/browser/extensions/window_open_apitest.cc

+++ b/chrome/browser/extensions/window_open_apitest.cc

@@ -191,12 +191,12 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PopupBlockingHostedApp) {

->GetURL(popup_app_contents_path + "open_popup.html")

.ReplaceComponents(replace_host);

- browser()->OpenURL(OpenURLParams(

- open_tab, Referrer(), NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_TYPED,

- false));

- browser()->OpenURL(OpenURLParams(

- open_popup, Referrer(), NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_TYPED, false));

+ browser()->OpenURL(OpenURLParams(open_tab, Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_TYPED, false));

+ browser()->OpenURL(OpenURLParams(open_popup, Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_TYPED, false));

EXPECT_TRUE(WaitForTabsAndPopups(browser(), 3, 1));

}