Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_tabstrip.cc ('k') | chrome/browser/ui/cocoa/applescript/tab_applescript.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/chrome_pages.cc
diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc
index cb5d5c59dfcaac9252402d17401b4cc3b4f5b97b..0d4739ee8c6dc5a68cf49c0a4b2d34ed6ac0683a 100644
--- a/chrome/browser/ui/chrome_pages.cc
+++ b/chrome/browser/ui/chrome_pages.cc
@@ -104,11 +104,11 @@ void ShowHelpImpl(Browser* browser, Profile* profile, HelpSource source) {
default:
NOTREACHED() << "Unhandled help source" << source;
}
- OpenApplication(
- AppLaunchParams(profile, extension,
- extensions::GetLaunchContainer(
- extensions::ExtensionPrefs::Get(profile), extension),
- NEW_FOREGROUND_TAB, app_launch_source, true));
+ OpenApplication(AppLaunchParams(
+ profile, extension,
+ extensions::GetLaunchContainer(extensions::ExtensionPrefs::Get(profile),
+ extension),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB, app_launch_source, true));
#else
GURL url;
switch (source) {
« no previous file with comments | « chrome/browser/ui/browser_tabstrip.cc ('k') | chrome/browser/ui/cocoa/applescript/tab_applescript.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698