chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/browser_action_apitest.cc ('k') | chrome/browser/extensions/api/management/chrome_management_api_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

diff --git a/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc b/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

index 3e922668d79cab78cb8770cd389f408a83dac046..35b9de583a74415a73b89929e9497006497306f5 100644

--- a/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

+++ b/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

@@ -97,10 +97,10 @@ IN_PROC_BROWSER_TEST_F(BrowserActionInteractiveTest, TestOpenPopup) {

content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,

content::NotificationService::AllSources());

// Open a new window.

- new_browser = chrome::FindBrowserWithWebContents(

- browser()->OpenURL(content::OpenURLParams(

- GURL("about:"), content::Referrer(), NEW_WINDOW,

- ui::PAGE_TRANSITION_TYPED, false)));

+ new_browser = chrome::FindBrowserWithWebContents(browser()->OpenURL(

+ content::OpenURLParams(GURL("about:"), content::Referrer(),

+ WindowOpenDisposition::NEW_WINDOW,

+ ui::PAGE_TRANSITION_TYPED, false)));

// Hide all the buttons to test that it opens even when the browser action

// is in the overflow bucket.

ToolbarActionsModel::Get(profile())->SetVisibleIconCount(0);

@@ -378,7 +378,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionInteractiveTest,

// Create a new browser window to prevent the message loop from terminating.

browser()->OpenURL(content::OpenURLParams(GURL("about:"), content::Referrer(),

- NEW_WINDOW,

+ WindowOpenDisposition::NEW_WINDOW,

ui::PAGE_TRANSITION_TYPED, false));

// Forcibly closing the browser HWND should not cause a crash.