Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
diff --git a/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc b/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
index 62fc536c535ab08ff45205f80d23768f8096f251..b5d7dbb1d8a66d43cf350a31190a1803c6635319 100644
--- a/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
@@ -196,7 +196,7 @@ void OpenAll(gfx::NativeWindow parent,
// When |initial_disposition| is OFF_THE_RECORD, a node which can't be
// opened in incognito window, it is detected using |browser_context|, is
// not opened.
- if (initial_disposition == OFF_THE_RECORD &&
+ if (initial_disposition == WindowOpenDisposition::OFF_THE_RECORD &&
!IsURLAllowedInIncognito(*url, browser_context))
continue;
@@ -206,7 +206,7 @@ void OpenAll(gfx::NativeWindow parent,
if (!opened_first_url) {
opened_first_url = true;
- disposition = NEW_BACKGROUND_TAB;
+ disposition = WindowOpenDisposition::NEW_BACKGROUND_TAB;
// We opened the first URL which may have opened a new window or clobbered
// the current page, reset the navigator just to be sure. |opened_tab| may
// be NULL in tests.
« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698