Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: chrome/browser/ui/app_list/start_page_service.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/app_list/app_list_view_delegate.cc ('k') | chrome/browser/ui/apps/chrome_app_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/start_page_service.cc
diff --git a/chrome/browser/ui/app_list/start_page_service.cc b/chrome/browser/ui/app_list/start_page_service.cc
index e94c8d2da653737dc1a47935ddbbc3bfff69dcd3..a8bd07ab41f392fab0637cce19e2326e36023fa4 100644
--- a/chrome/browser/ui/app_list/start_page_service.cc
+++ b/chrome/browser/ui/app_list/start_page_service.cc
@@ -182,15 +182,11 @@ class StartPageService::StartPageWebContentsDelegate
chrome::ScopedTabbedBrowserDisplayer displayer(profile_);
// Force all links to open in a new tab, even if they were trying to open a
// new window.
- disposition =
- disposition == NEW_BACKGROUND_TAB ? disposition : NEW_FOREGROUND_TAB;
- chrome::AddWebContents(displayer.browser(),
- nullptr,
- new_contents,
- disposition,
- initial_pos,
- user_gesture,
- was_blocked);
+ disposition = disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB
+ ? disposition
+ : WindowOpenDisposition::NEW_FOREGROUND_TAB;
+ chrome::AddWebContents(displayer.browser(), nullptr, new_contents,
+ disposition, initial_pos, user_gesture, was_blocked);
}
content::WebContents* OpenURLFromTab(
@@ -200,10 +196,10 @@ class StartPageService::StartPageWebContentsDelegate
// window.
chrome::NavigateParams new_tab_params(
static_cast<Browser*>(nullptr), params.url, params.transition);
- if (params.disposition == NEW_BACKGROUND_TAB) {
- new_tab_params.disposition = NEW_BACKGROUND_TAB;
+ if (params.disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB) {
+ new_tab_params.disposition = WindowOpenDisposition::NEW_BACKGROUND_TAB;
} else {
- new_tab_params.disposition = NEW_FOREGROUND_TAB;
+ new_tab_params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
new_tab_params.window_action = chrome::NavigateParams::SHOW_WINDOW;
}
« no previous file with comments | « chrome/browser/ui/app_list/app_list_view_delegate.cc ('k') | chrome/browser/ui/apps/chrome_app_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698