chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('k') | chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm

index 9d80639675137f4cd0fcd8d605d712e5fb4142fb..a1475c79d5e0359bc9f83a7ae1ec0ce857510e03 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm

@@ -409,7 +409,7 @@ NSTextField* AddTextField(

chrome::NavigateParams params(

browser_, GURL(chrome::kChromeEnterpriseSignInLearnMoreURL),

ui::PAGE_TRANSITION_AUTO_TOPLEVEL);

- params.disposition = NEW_POPUP;

+ params.disposition = WindowOpenDisposition::NEW_POPUP;

params.window_action = chrome::NavigateParams::SHOW_WINDOW;

chrome::Navigate(&params);

}