chrome/browser/chromeos/arc/arc_auth_service.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_auth_service.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/arc/arc_auth_service.cc

diff --git a/chrome/browser/chromeos/arc/arc_auth_service.cc b/chrome/browser/chromeos/arc/arc_auth_service.cc

index 997507111c74836e322062ae0f1242ca60725ea8..20c6bde299bf4c483288f613ec66195fb6ab04f6 100644

--- a/chrome/browser/chromeos/arc/arc_auth_service.cc

+++ b/chrome/browser/chromeos/arc/arc_auth_service.cc

@@ -518,7 +518,8 @@ void ArcAuthService::ShowUI(UIPage page, const base::string16& status) {

ArcSupportHost::kHostAppId, profile_));

OpenApplication(CreateAppLaunchParamsUserContainer(

- profile_, extension, NEW_WINDOW, extensions::SOURCE_CHROME_INTERNAL));

+ profile_, extension, WindowOpenDisposition::NEW_WINDOW,

+ extensions::SOURCE_CHROME_INTERNAL));

}

void ArcAuthService::OnContextReady() {