Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h" 5 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "chrome/app/chrome_command_ids.h" 10 #include "chrome/app/chrome_command_ids.h"
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 passwords_data_.ChooseCredential(&copy_form); 320 passwords_data_.ChooseCredential(&copy_form);
321 passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE); 321 passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
322 UpdateBubbleAndIconVisibility(); 322 UpdateBubbleAndIconVisibility();
323 } 323 }
324 324
325 void ManagePasswordsUIController::NavigateToExternalPasswordManager() { 325 void ManagePasswordsUIController::NavigateToExternalPasswordManager() {
326 chrome::NavigateParams params( 326 chrome::NavigateParams params(
327 chrome::FindBrowserWithWebContents(web_contents()), 327 chrome::FindBrowserWithWebContents(web_contents()),
328 GURL(password_manager::kPasswordManagerAccountDashboardURL), 328 GURL(password_manager::kPasswordManagerAccountDashboardURL),
329 ui::PAGE_TRANSITION_LINK); 329 ui::PAGE_TRANSITION_LINK);
330 params.disposition = NEW_FOREGROUND_TAB; 330 params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
331 chrome::Navigate(&params); 331 chrome::Navigate(&params);
332 } 332 }
333 333
334 void ManagePasswordsUIController::NavigateToSmartLockHelpPage() { 334 void ManagePasswordsUIController::NavigateToSmartLockHelpPage() {
335 chrome::NavigateParams params( 335 chrome::NavigateParams params(
336 chrome::FindBrowserWithWebContents(web_contents()), 336 chrome::FindBrowserWithWebContents(web_contents()),
337 GURL(chrome::kSmartLockHelpPage), ui::PAGE_TRANSITION_LINK); 337 GURL(chrome::kSmartLockHelpPage), ui::PAGE_TRANSITION_LINK);
338 params.disposition = NEW_FOREGROUND_TAB; 338 params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
339 chrome::Navigate(&params); 339 chrome::Navigate(&params);
340 } 340 }
341 341
342 void ManagePasswordsUIController::NavigateToPasswordManagerSettingsPage() { 342 void ManagePasswordsUIController::NavigateToPasswordManagerSettingsPage() {
343 chrome::ShowSettingsSubPage( 343 chrome::ShowSettingsSubPage(
344 chrome::FindBrowserWithWebContents(web_contents()), 344 chrome::FindBrowserWithWebContents(web_contents()),
345 chrome::kPasswordManagerSubPage); 345 chrome::kPasswordManagerSubPage);
346 } 346 }
347 347
348 void ManagePasswordsUIController::NavigateToChromeSignIn() { 348 void ManagePasswordsUIController::NavigateToChromeSignIn() {
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE); 451 passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
452 } 452 }
453 } 453 }
454 454
455 void ManagePasswordsUIController::WebContentsDestroyed() { 455 void ManagePasswordsUIController::WebContentsDestroyed() {
456 password_manager::PasswordStore* password_store = 456 password_manager::PasswordStore* password_store =
457 GetPasswordStore(web_contents()); 457 GetPasswordStore(web_contents());
458 if (password_store) 458 if (password_store)
459 password_store->RemoveObserver(this); 459 password_store->RemoveObserver(this);
460 } 460 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('k') | chrome/browser/ui/pdf/pdf_unsupported_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698