Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/one_click_signin_view_controller.mm
diff --git a/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm b/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm
index afba24fced1e738d2c1160f5e2d44216ca80949e..6ed318a4d75d7270c78a9d4f7d2fffd122282677 100644
--- a/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm
+++ b/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm
@@ -111,9 +111,9 @@ void ShiftOriginY(NSView* view, CGFloat amount) {
OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST);
}
else {
- content::OpenURLParams params(GURL(chrome::kChromeUISettingsURL),
- content::Referrer(), CURRENT_TAB,
- ui::PAGE_TRANSITION_LINK, false);
+ content::OpenURLParams params(
+ GURL(chrome::kChromeUISettingsURL), content::Referrer(),
+ WindowOpenDisposition::CURRENT_TAB, ui::PAGE_TRANSITION_LINK, false);
webContents_->OpenURL(params);
}
[self close];
@@ -288,8 +288,9 @@ void ShiftOriginY(NSView* view, CGFloat amount) {
signin_metrics::LogSigninConfirmHistogramValue(
signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE);
}
- WindowOpenDisposition location = isSyncDialog_ ?
- NEW_WINDOW : NEW_FOREGROUND_TAB;
+ WindowOpenDisposition location =
+ isSyncDialog_ ? WindowOpenDisposition::NEW_WINDOW
+ : WindowOpenDisposition::NEW_FOREGROUND_TAB;
content::OpenURLParams params(GURL(chrome::kChromeSyncLearnMoreURL),
content::Referrer(), location,
ui::PAGE_TRANSITION_LINK, false);
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm ('k') | chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698