chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc ('k') | chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

index 2143adce9f67745082305d53277f72a1e5794eaf..c9f9b79d2e12ce3fa2f1c6181dc90526a8f8d2d3 100644

--- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

@@ -112,7 +112,8 @@ TEST_F(BookmarkContextMenuControllerTest, DeleteURL) {

// Tests open all on a folder with a couple of bookmarks.

TEST_F(BookmarkContextMenuControllerTest, OpenAll) {

const BookmarkNode* folder = model_->bookmark_bar_node()->GetChild(1);

- chrome::OpenAll(NULL, &navigator_, folder, NEW_FOREGROUND_TAB, NULL);

+ chrome::OpenAll(NULL, &navigator_, folder,

+ WindowOpenDisposition::NEW_FOREGROUND_TAB, NULL);

// Should have navigated to F1's child, but not F11's child.

ASSERT_EQ(static_cast<size_t>(1), navigator_.urls_.size());