pdf/pdfium/pdfium_engine.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdfium/pdfium_engine.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/pdfium/pdfium_engine.cc

diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc

index fffb19846573890b7e4dd78485ca4b27b79ae66f..281b1d5f45807dc4f1af13e784e6f8e59d6aadf4 100644

--- a/pdf/pdfium/pdfium_engine.cc

+++ b/pdf/pdfium/pdfium_engine.cc

@@ -3557,7 +3557,8 @@ void PDFiumEngine::Form_SetTextFieldFocus(FPDF_FORMFILLINFO* param,

void PDFiumEngine::Form_DoURIAction(FPDF_FORMFILLINFO* param,

FPDF_BYTESTRING uri) {

PDFiumEngine* engine = static_cast<PDFiumEngine*>(param);

- engine->client_->NavigateTo(std::string(uri), CURRENT_TAB);

+ engine->client_->NavigateTo(std::string(uri),

+ WindowOpenDisposition::CURRENT_TAB);

}

void PDFiumEngine::Form_DoGoToAction(FPDF_FORMFILLINFO* param,

« no previous file with comments | « pdf/out_of_process_instance.cc ('k') | services/navigation/view_impl.cc » ('j') | no next file with comments »