Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3706)

Unified Diff: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc
index a5b3c0b719a1e4b2c8cf2171d9c5a87af04cbdd3..a2d08b5ed6b7a0b7f9c1f79ed711f309dd777364 100644
--- a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc
@@ -43,7 +43,7 @@ PasswordManagerInternalsWebUIBrowserTest::
void PasswordManagerInternalsWebUIBrowserTest::SetUpOnMainThread() {
WebUIBrowserTest::SetUpOnMainThread();
- OpenInternalsPage(CURRENT_TAB);
+ OpenInternalsPage(WindowOpenDisposition::CURRENT_TAB);
AddLibrary(base::FilePath(
FILE_PATH_LITERAL("password_manager_internals_browsertest.js")));
}
@@ -100,7 +100,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,
GetForBrowserContext(browser()->profile());
ASSERT_TRUE(service);
service->ProcessLog("<script> text for testing");
- OpenInternalsPage(CURRENT_TAB); // Reload.
+ OpenInternalsPage(WindowOpenDisposition::CURRENT_TAB); // Reload.
ASSERT_TRUE(RunJavascriptTest("testLogEmpty"));
}
@@ -119,7 +119,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,
service->ProcessLog("<script> text for testing");
ASSERT_TRUE(RunJavascriptTest("testLogText"));
// Now open a second tab with the internals page, but do not log anything.
- OpenInternalsPage(NEW_FOREGROUND_TAB);
+ OpenInternalsPage(WindowOpenDisposition::NEW_FOREGROUND_TAB);
// The previously logged text should have made it to the page.
ASSERT_TRUE(RunJavascriptTest("testLogText"));
}
@@ -129,7 +129,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,
IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,
LogSavePasswordProgress_NotFlushedOnReloadIfMultiple) {
// Open one more tab with the internals page.
- OpenInternalsPage(NEW_FOREGROUND_TAB);
+ OpenInternalsPage(WindowOpenDisposition::NEW_FOREGROUND_TAB);
// Now log something.
password_manager::PasswordManagerInternalsService* service =
password_manager::PasswordManagerInternalsServiceFactory::
@@ -137,7 +137,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,
ASSERT_TRUE(service);
service->ProcessLog("<script> text for testing");
// Reload.
- OpenInternalsPage(CURRENT_TAB);
+ OpenInternalsPage(WindowOpenDisposition::CURRENT_TAB);
// The text should still be there.
ASSERT_TRUE(RunJavascriptTest("testLogText"));
}
@@ -171,7 +171,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,
password_manager::PasswordManagerInternalsServiceFactory::
GetForBrowserContext(incognito->profile()->GetOffTheRecordProfile());
EXPECT_FALSE(service); // There should be no service for Incognito.
- OpenInternalsPageWithBrowser(incognito, CURRENT_TAB);
+ OpenInternalsPageWithBrowser(incognito, WindowOpenDisposition::CURRENT_TAB);
SetWebUIInstance(
incognito->tab_strip_model()->GetActiveWebContents()->GetWebUI());
ASSERT_TRUE(RunJavascriptTest("testIncognitoDescription"));

Powered by Google App Engine
This is Rietveld 408576698