chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

index 1c3e48b997d47b50a611e2ef6ba960890fb926d4..bbbbed171ab329574e7c10d610968d9a204b2207 100644

--- a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

@@ -228,9 +228,7 @@ void NetInternalsTest::MessageHandler::LoadPage(

ASSERT_TRUE(list_value->GetString(0, &url));

LOG(WARNING) << "url: [" << url << "]";

ui_test_utils::NavigateToURLWithDisposition(

- browser(),

- GURL(url),

- NEW_BACKGROUND_TAB,

+ browser(), GURL(url), WindowOpenDisposition::NEW_BACKGROUND_TAB,

ui_test_utils::BROWSER_TEST_NONE);

}

@@ -241,9 +239,7 @@ void NetInternalsTest::MessageHandler::PrerenderPage(

GURL loader_url =

net_internals_test_->CreatePrerenderLoaderUrl(GURL(prerender_url));

ui_test_utils::NavigateToURLWithDisposition(

- browser(),

- GURL(loader_url),

- NEW_BACKGROUND_TAB,

+ browser(), GURL(loader_url), WindowOpenDisposition::NEW_BACKGROUND_TAB,

ui_test_utils::BROWSER_TEST_NONE);

}