chrome/browser/apps/app_window_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_window_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/app_window_browsertest.cc

diff --git a/chrome/browser/apps/app_window_browsertest.cc b/chrome/browser/apps/app_window_browsertest.cc

index b85606b5e599c660ce2051877b62c0c1dcbabcef..2dc8f4c26f63638e1663901ddbb77ae2d3d6b799 100644

--- a/chrome/browser/apps/app_window_browsertest.cc

+++ b/chrome/browser/apps/app_window_browsertest.cc

@@ -218,9 +218,9 @@ IN_PROC_BROWSER_TEST_F(AppWindowAPITest,

test_data_dir_.AppendASCII("platform_apps").AppendASCII("window_api"));

EXPECT_TRUE(extension);

- OpenApplication(AppLaunchParams(browser()->profile(), extension,

- extensions::LAUNCH_CONTAINER_NONE, NEW_WINDOW,

- extensions::SOURCE_TEST));

+ OpenApplication(AppLaunchParams(

+ browser()->profile(), extension, extensions::LAUNCH_CONTAINER_NONE,

+ WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_TEST));

ExtensionTestMessageListener geometry_listener("ListenGeometryChange", true);