Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: chrome/browser/ui/extensions/hosted_app_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/hosted_app_browsertest.cc
diff --git a/chrome/browser/ui/extensions/hosted_app_browsertest.cc b/chrome/browser/ui/extensions/hosted_app_browsertest.cc
index 07b1874f28a3257501177772c5e330cb18457eb2..48b387ac41d97dc958eff05134ca52cb9af2001c 100644
--- a/chrome/browser/ui/extensions/hosted_app_browsertest.cc
+++ b/chrome/browser/ui/extensions/hosted_app_browsertest.cc
@@ -60,7 +60,7 @@ class HostedAppTest : public ExtensionBrowserTest {
// Launch it in a window.
ASSERT_TRUE(OpenApplication(AppLaunchParams(
browser()->profile(), app, extensions::LAUNCH_CONTAINER_WINDOW,
- NEW_WINDOW, extensions::SOURCE_TEST)));
+ WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_TEST)));
for (auto* b : *BrowserList::GetInstance()) {
if (b == browser())
@@ -199,7 +199,7 @@ IN_PROC_BROWSER_TEST_F(HostedAppTest, ShouldUseWebAppFrame) {
// Launch it in a window, as AppLauncherHandler::HandleLaunchApp() would.
WebContents* bookmark_app_window = OpenApplication(AppLaunchParams(
browser()->profile(), bookmark_app, extensions::LAUNCH_CONTAINER_WINDOW,
- NEW_WINDOW, extensions::SOURCE_UNTRACKED));
+ WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_UNTRACKED));
ASSERT_TRUE(bookmark_app_window);
// Load a packaged app.
@@ -217,7 +217,7 @@ IN_PROC_BROWSER_TEST_F(HostedAppTest, ShouldUseWebAppFrame) {
// Launch it in a window, as AppLauncherHandler::HandleLaunchApp() would.
WebContents* packaged_app_window = OpenApplication(AppLaunchParams(
browser()->profile(), packaged_app, extensions::LAUNCH_CONTAINER_WINDOW,
- NEW_WINDOW, extensions::SOURCE_UNTRACKED));
+ WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_UNTRACKED));
ASSERT_TRUE(packaged_app_window);
DevToolsWindow* devtools_window =

Powered by Google App Engine
This is Rietveld 408576698