Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/website_settings/website_settings_bubble_contro ller.h" 5 #import "chrome/browser/ui/cocoa/website_settings/website_settings_bubble_contro ller.h"
6 6
7 #import <AppKit/AppKit.h> 7 #import <AppKit/AppKit.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 10
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 } 386 }
387 387
388 // Handler for the site settings button below the list of permissions. 388 // Handler for the site settings button below the list of permissions.
389 - (void)showSiteSettingsData:(id)sender { 389 - (void)showSiteSettingsData:(id)sender {
390 DCHECK(webContents_); 390 DCHECK(webContents_);
391 DCHECK(presenter_); 391 DCHECK(presenter_);
392 presenter_->RecordWebsiteSettingsAction( 392 presenter_->RecordWebsiteSettingsAction(
393 WebsiteSettings::WEBSITE_SETTINGS_SITE_SETTINGS_OPENED); 393 WebsiteSettings::WEBSITE_SETTINGS_SITE_SETTINGS_OPENED);
394 webContents_->OpenURL(content::OpenURLParams( 394 webContents_->OpenURL(content::OpenURLParams(
395 GURL(chrome::kChromeUIContentSettingsURL), content::Referrer(), 395 GURL(chrome::kChromeUIContentSettingsURL), content::Referrer(),
396 NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK, false)); 396 WindowOpenDisposition::NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK,
397 false));
397 } 398 }
398 399
399 // Handler for the site settings button below the list of permissions. 400 // Handler for the site settings button below the list of permissions.
400 // TODO(lgarron): Move some of this to the presenter for separation of concerns 401 // TODO(lgarron): Move some of this to the presenter for separation of concerns
401 // and platform unification. (https://crbug.com/571533) 402 // and platform unification. (https://crbug.com/571533)
402 - (void)showSecurityDetails:(id)sender { 403 - (void)showSecurityDetails:(id)sender {
403 DCHECK(webContents_); 404 DCHECK(webContents_);
404 DCHECK(presenter_); 405 DCHECK(presenter_);
405 presenter_->RecordWebsiteSettingsAction( 406 presenter_->RecordWebsiteSettingsAction(
406 WebsiteSettings::WEBSITE_SETTINGS_SECURITY_DETAILS_OPENED); 407 WebsiteSettings::WEBSITE_SETTINGS_SECURITY_DETAILS_OPENED);
(...skipping 789 matching lines...) Expand 10 before | Expand all | Expand 10 after
1196 void WebsiteSettingsUIBridge::SetPermissionInfo( 1197 void WebsiteSettingsUIBridge::SetPermissionInfo(
1197 const PermissionInfoList& permission_info_list, 1198 const PermissionInfoList& permission_info_list,
1198 const ChosenObjectInfoList& chosen_object_info_list) { 1199 const ChosenObjectInfoList& chosen_object_info_list) {
1199 [bubble_controller_ setPermissionInfo:permission_info_list 1200 [bubble_controller_ setPermissionInfo:permission_info_list
1200 andChosenObjects:chosen_object_info_list]; 1201 andChosenObjects:chosen_object_info_list];
1201 } 1202 }
1202 1203
1203 void WebsiteSettingsUIBridge::SetSelectedTab(TabId tab_id) { 1204 void WebsiteSettingsUIBridge::SetSelectedTab(TabId tab_id) {
1204 // TODO(lgarron): Remove this from the interface. (crbug.com/571533) 1205 // TODO(lgarron): Remove this from the interface. (crbug.com/571533)
1205 } 1206 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/view_id_util_browsertest.mm ('k') | chrome/browser/ui/exclusive_access/fullscreen_controller_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698