chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

index a79c9d9624f417a5258b78ebde3e67645e8df33f..c450c4e7ed5b77d5da07f64fdac859fb75bd88dd 100644

--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

@@ -292,8 +292,10 @@ void RecentTabsSubMenuModel::ExecuteCommand(int command_id, int event_flags) {

WindowOpenDisposition disposition =

ui::DispositionFromEventFlags(event_flags);

- if (disposition == CURRENT_TAB) // Force to open a new foreground tab.

- disposition = NEW_FOREGROUND_TAB;

+ if (disposition == WindowOpenDisposition::CURRENT_TAB) {

+ // Force to open a new foreground tab.

+ disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;

+ }

sessions::TabRestoreService* service =

TabRestoreServiceFactory::GetForProfile(browser_->profile());