Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7151)

Unified Diff: chrome/browser/ui/webui/options/options_ui_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/options_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/options/options_ui_browsertest.cc b/chrome/browser/ui/webui/options/options_ui_browsertest.cc
index 7bf85275110a9c96a58cb00284305369f60da43d..255cc61f6d87838acdf6d43728cbc808be930ce9 100644
--- a/chrome/browser/ui/webui/options/options_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/options/options_ui_browsertest.cc
@@ -114,7 +114,8 @@ void OptionsUIBrowserTest::NavigateToSettings() {
void OptionsUIBrowserTest::NavigateToSettingsSubpage(
const std::string& sub_page) {
const GURL& url = chrome::GetSettingsUrl(sub_page);
- ui_test_utils::NavigateToURLWithDisposition(browser(), url, CURRENT_TAB, 0);
+ ui_test_utils::NavigateToURLWithDisposition(
+ browser(), url, WindowOpenDisposition::CURRENT_TAB, 0);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
@@ -299,7 +300,7 @@ IN_PROC_BROWSER_TEST_F(OptionsUIBrowserTest, NavigateBackFromOverlayDialog) {
// Go back to the settings page.
content::TestNavigationObserver observer(contents);
- chrome::GoBack(browser(), CURRENT_TAB);
+ chrome::GoBack(browser(), WindowOpenDisposition::CURRENT_TAB);
observer.Wait();
// Verify that the settings page lists one profile.

Powered by Google App Engine
This is Rietveld 408576698