Convert WindowOpenDisposition to an enum class.

chrome/browser/ui/extensions/hosted_app_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "chrome/browser/devtools/devtools_window_testing.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
@@ skipping 42 matching lines @@
     const Extension* app = InstallExtensionWithSourceAndFlags(
         test_data_dir_.AppendASCII(app_folder), 1,
         extensions::Manifest::INTERNAL,
         is_bookmark_app ? extensions::Extension::FROM_BOOKMARK
                         : extensions::Extension::NO_FLAGS);
     ASSERT_TRUE(app);
 
     // Launch it in a window.
     ASSERT_TRUE(OpenApplication(AppLaunchParams(
         browser()->profile(), app, extensions::LAUNCH_CONTAINER_WINDOW,
-        NEW_WINDOW, extensions::SOURCE_TEST)));
+        WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_TEST)));
 
     for (auto* b : *BrowserList::GetInstance()) {
       if (b == browser())
         continue;
 
       std::string browser_app_id =
           web_app::GetExtensionIdFromApplicationName(b->app_name());
       if (browser_app_id == app->id()) {
         app_browser_ = b;
         break;
@@ skipping 118 matching lines @@
    const Extension* bookmark_app = InstallExtensionWithSourceAndFlags(
       test_data_dir_.AppendASCII("app"),
       1,
       extensions::Manifest::INTERNAL,
       extensions::Extension::FROM_BOOKMARK);
   ASSERT_TRUE(bookmark_app);
 
   // Launch it in a window, as AppLauncherHandler::HandleLaunchApp() would.
   WebContents* bookmark_app_window = OpenApplication(AppLaunchParams(
       browser()->profile(), bookmark_app, extensions::LAUNCH_CONTAINER_WINDOW,
-      NEW_WINDOW, extensions::SOURCE_UNTRACKED));
+      WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_UNTRACKED));
   ASSERT_TRUE(bookmark_app_window);
 
   //  Load a packaged app.
   ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("packaged_app")));
   const Extension* packaged_app = nullptr;
   extensions::ExtensionRegistry* registry =
       extensions::ExtensionRegistry::Get(browser()->profile());
   for (const scoped_refptr<const extensions::Extension>& extension :
        registry->enabled_extensions()) {
     if (extension->name() == "Packaged App Test")
       packaged_app = extension.get();
   }
   ASSERT_TRUE(packaged_app);
 
   // Launch it in a window, as AppLauncherHandler::HandleLaunchApp() would.
   WebContents* packaged_app_window = OpenApplication(AppLaunchParams(
       browser()->profile(), packaged_app, extensions::LAUNCH_CONTAINER_WINDOW,
-      NEW_WINDOW, extensions::SOURCE_UNTRACKED));
+      WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_UNTRACKED));
   ASSERT_TRUE(packaged_app_window);
 
   DevToolsWindow* devtools_window =
       DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), false);
 
   // The launch should have created a new app browser and a dev tools browser.
   ASSERT_EQ(4u, chrome::GetBrowserCount(browser()->profile()));
 
   // Find the new browsers.
   Browser* bookmark_app_browser = nullptr;
@@ skipping 26 matching lines @@
 #else
   const bool kIsAsh = false;
 #endif  // USE_ASH
   EXPECT_EQ(kIsAsh, bookmark_app_browser->SupportsWindowFeature(
                         Browser::FEATURE_WEBAPPFRAME));
   EXPECT_FALSE(packaged_app_browser->SupportsWindowFeature(
       Browser::FEATURE_WEBAPPFRAME));
 
   DevToolsWindowTesting::CloseDevToolsWindowSync(devtools_window);
 }