chrome/browser/apps/install_chrome_app.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/install_chrome_app.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/install_chrome_app.cc

diff --git a/chrome/browser/apps/install_chrome_app.cc b/chrome/browser/apps/install_chrome_app.cc

index 0f5fc2fa66f1e43481d27549e5f793b8e2a3193f..06b33d038d06b7628e4dbd5ed03b8baeb1fb3d1b 100644

--- a/chrome/browser/apps/install_chrome_app.cc

+++ b/chrome/browser/apps/install_chrome_app.cc

@@ -83,11 +83,9 @@ void InstallChromeApp(const std::string& app_id) {

Browser* browser = BrowserList::GetInstance()->get(0);

DCHECK(browser);

- content::OpenURLParams params(GetAppInstallUrl(app_id),

- content::Referrer(),

- NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_AUTO_TOPLEVEL,

- false);

+ content::OpenURLParams params(GetAppInstallUrl(app_id), content::Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false);

browser->OpenURL(params);

ExtensionRegistry* registry = ExtensionRegistry::Get(browser->profile());