Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2050)

Unified Diff: content/public/browser/web_contents_delegate.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/page_navigator.cc ('k') | content/public/common/common_param_traits_macros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_delegate.cc
diff --git a/content/public/browser/web_contents_delegate.cc b/content/public/browser/web_contents_delegate.cc
index df973484d0d98a93526ab6b06869e9c4a28a570b..74e59b1a195281723c21f9992a8d7e1396eafed4 100644
--- a/content/public/browser/web_contents_delegate.cc
+++ b/content/public/browser/web_contents_delegate.cc
@@ -96,9 +96,10 @@ void WebContentsDelegate::ViewSourceForTab(WebContents* source,
// It suffers from http://crbug.com/523 and that is why browser overrides
// it with proper implementation.
GURL url = GURL(kViewSourceScheme + std::string(":") + page_url.spec());
- OpenURLFromTab(source, OpenURLParams(url, Referrer(),
- NEW_FOREGROUND_TAB,
- ui::PAGE_TRANSITION_LINK, false));
+ OpenURLFromTab(
+ source,
+ OpenURLParams(url, Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui::PAGE_TRANSITION_LINK, false));
}
void WebContentsDelegate::ViewSourceForFrame(WebContents* source,
@@ -106,9 +107,10 @@ void WebContentsDelegate::ViewSourceForFrame(WebContents* source,
const PageState& page_state) {
// Same as ViewSourceForTab, but for given subframe.
GURL url = GURL(kViewSourceScheme + std::string(":") + frame_url.spec());
- OpenURLFromTab(source, OpenURLParams(url, Referrer(),
- NEW_FOREGROUND_TAB,
- ui::PAGE_TRANSITION_LINK, false));
+ OpenURLFromTab(
+ source,
+ OpenURLParams(url, Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui::PAGE_TRANSITION_LINK, false));
}
bool WebContentsDelegate::PreHandleKeyboardEvent(
« no previous file with comments | « content/public/browser/page_navigator.cc ('k') | content/public/common/common_param_traits_macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698