Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/ui/ash/chrome_new_window_delegate.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/chrome_new_window_delegate.cc
diff --git a/chrome/browser/ui/ash/chrome_new_window_delegate.cc b/chrome/browser/ui/ash/chrome_new_window_delegate.cc
index 68ac5dfeab0a1085f796a1a58dc1c0fc9e7301f2..57088d9d5dec5b8438ff3a758628ce5bea1399da 100644
--- a/chrome/browser/ui/ash/chrome_new_window_delegate.cc
+++ b/chrome/browser/ui/ash/chrome_new_window_delegate.cc
@@ -133,7 +133,8 @@ void ChromeNewWindowDelegate::OpenFileManager() {
const extensions::Extension* const extension =
service->GetInstalledExtension(kFileManagerAppId);
OpenApplication(CreateAppLaunchParamsUserContainer(
- profile, extension, NEW_FOREGROUND_TAB, extensions::SOURCE_KEYBOARD));
+ profile, extension, WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ extensions::SOURCE_KEYBOARD));
}
void ChromeNewWindowDelegate::OpenCrosh() {
@@ -144,9 +145,9 @@ void ChromeNewWindowDelegate::OpenCrosh() {
return;
chrome::ScopedTabbedBrowserDisplayer displayer(profile);
Browser* browser = displayer.browser();
- content::WebContents* page = browser->OpenURL(
- content::OpenURLParams(crosh_url, content::Referrer(), NEW_FOREGROUND_TAB,
- ui::PAGE_TRANSITION_GENERATED, false));
+ content::WebContents* page = browser->OpenURL(content::OpenURLParams(
+ crosh_url, content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui::PAGE_TRANSITION_GENERATED, false));
browser->window()->Show();
browser->window()->Activate();
page->Focus();
« no previous file with comments | « chrome/browser/ui/ash/cast_config_delegate_chromeos.cc ('k') | chrome/browser/ui/ash/chrome_shell_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698