chrome/browser/extensions/webstore_inline_installer_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_inline_installer_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_inline_installer_browsertest.cc

diff --git a/chrome/browser/extensions/webstore_inline_installer_browsertest.cc b/chrome/browser/extensions/webstore_inline_installer_browsertest.cc

index a2a25b7bda28e4da75a5667a87f3a95a2aa800b8..91ad7cfac307c2a26be994028f042f20fc42bb77 100644

--- a/chrome/browser/extensions/webstore_inline_installer_browsertest.cc

+++ b/chrome/browser/extensions/webstore_inline_installer_browsertest.cc

@@ -357,7 +357,8 @@ IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerListenerTest, BothListenersTest) {

int old_tab_index = browser()->tab_strip_model()->active_index();

ui_test_utils::NavigateToURLWithDisposition(

browser(), GenerateTestServerUrl(kAppDomain, "both_listeners.html"),

- NEW_FOREGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

DCHECK_NE(old_tab_index, browser()->tab_strip_model()->active_index());

browser()->tab_strip_model()->CloseWebContentsAt(old_tab_index,

TabStripModel::CLOSE_NONE);