Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: chrome/browser/ui/views/frame/global_menu_bar_x11.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/global_menu_bar_x11.cc
diff --git a/chrome/browser/ui/views/frame/global_menu_bar_x11.cc b/chrome/browser/ui/views/frame/global_menu_bar_x11.cc
index f38f35302ee13348336ce6e98222cab38649535a..3e3e8a6eaa1bd1ab41485871094424783565d6d3 100644
--- a/chrome/browser/ui/views/frame/global_menu_bar_x11.cc
+++ b/chrome/browser/ui/views/frame/global_menu_bar_x11.cc
@@ -850,15 +850,13 @@ void GlobalMenuBarX11::OnHistoryItemActivated(DbusmenuMenuitem* sender,
TabRestoreServiceFactory::GetForProfile(profile_);
if (item->session_id && service) {
service->RestoreEntryById(browser_->live_tab_context(), item->session_id,
- UNKNOWN);
+ WindowOpenDisposition::UNKNOWN);
} else {
DCHECK(item->url.is_valid());
- browser_->OpenURL(content::OpenURLParams(
- item->url,
- content::Referrer(),
- NEW_FOREGROUND_TAB,
- ui::PAGE_TRANSITION_AUTO_BOOKMARK,
- false));
+ browser_->OpenURL(
+ content::OpenURLParams(item->url, content::Referrer(),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));
}
}

Powered by Google App Engine
This is Rietveld 408576698