chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc ('k') | chrome/browser/extensions/api/extension_action/browser_action_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

index 008ea54f7ed9efec120c4583f7af7f65d7cb0497..8e3b0753cb8223c60eb8768ee9faf1ed8657d891 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

@@ -497,7 +497,8 @@ class DownloadExtensionTest : public ExtensionApiTest {

CreateDownloadObserver(1));

GURL finish_url(net::URLRequestSlowDownloadJob::kFinishDownloadUrl);

ui_test_utils::NavigateToURLWithDisposition(

- current_browser(), finish_url, NEW_FOREGROUND_TAB,

+ current_browser(), finish_url,

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

observer->WaitForFinished();

EXPECT_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::COMPLETE));

@@ -4035,8 +4036,7 @@ IN_PROC_BROWSER_TEST_F(

ui_test_utils::NavigateToURLWithDisposition(

current_browser(),

GURL(net::URLRequestSlowDownloadJob::kUnknownSizeUrl),

- CURRENT_TAB,

- ui_test_utils::BROWSER_TEST_NONE);

+ WindowOpenDisposition::CURRENT_TAB, ui_test_utils::BROWSER_TEST_NONE);

observer->WaitForFinished();

EXPECT_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::IN_PROGRESS));

DownloadManager::DownloadVector items;

@@ -4075,7 +4075,7 @@ IN_PROC_BROWSER_TEST_F(

ui_test_utils::NavigateToURLWithDisposition(

current_browser(),

GURL(net::URLRequestSlowDownloadJob::kErrorDownloadUrl),

- NEW_BACKGROUND_TAB,

+ WindowOpenDisposition::NEW_BACKGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

// Errors caught before filename determination are delayed until after