chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

diff --git a/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc b/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

index 053a6476c1a166621ebc93e3793f801ce27ce34c..40b00405d049b60ac0842a5008cd9f844bcd1c91 100644

--- a/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

+++ b/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

@@ -115,7 +115,8 @@ void AppListControllerDelegateImpl::LaunchApp(

AppListServiceImpl::RecordAppListAppLaunch();

AppLaunchParams params = CreateAppLaunchParamsUserContainer(

- profile, extension, NEW_FOREGROUND_TAB, extensions::SOURCE_APP_LAUNCHER);

+ profile, extension, WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ extensions::SOURCE_APP_LAUNCHER);

if (source != LAUNCH_FROM_UNKNOWN &&

extension->id() == extensions::kWebStoreAppId) {