pdf/out_of_process_instance.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/out_of_process_instance.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/out_of_process_instance.cc

diff --git a/pdf/out_of_process_instance.cc b/pdf/out_of_process_instance.cc

index af5d1a506fbb8c64c9d74bcee18c1e3df6091654..42eceb1fc66189d42e9f11e874dffebe699ba169 100644

--- a/pdf/out_of_process_instance.cc

+++ b/pdf/out_of_process_instance.cc

@@ -980,7 +980,8 @@ void OutOfProcessInstance::NavigateTo(const std::string& url,

pp::VarDictionary message;

message.Set(kType, kJSNavigateType);

message.Set(kJSNavigateUrl, url);

- message.Set(kJSNavigateWindowOpenDisposition, pp::Var(disposition));

+ message.Set(kJSNavigateWindowOpenDisposition,

+ pp::Var(static_cast<int32_t>(disposition)));

PostMessage(message);

}

« no previous file with comments | « ios/web/navigation/navigation_manager_impl.mm ('k') | pdf/pdfium/pdfium_engine.cc » ('j') | no next file with comments »