chrome/browser/ui/extensions/extension_installed_notification.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_installed_notification.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/extension_installed_notification.cc

diff --git a/chrome/browser/ui/extensions/extension_installed_notification.cc b/chrome/browser/ui/extensions/extension_installed_notification.cc

index 87b155d161b7be9d21f532c94f2fa0eee48ecf15..e424177dffd9b46cdd5e8914c64329b12c8bed0e 100644

--- a/chrome/browser/ui/extensions/extension_installed_notification.cc

+++ b/chrome/browser/ui/extensions/extension_installed_notification.cc

@@ -69,7 +69,7 @@ void ExtensionInstalledNotification::Click() {

return;

AppLaunchParams params = CreateAppLaunchParamsUserContainer(

- profile_, extension, NEW_FOREGROUND_TAB,

+ profile_, extension, WindowOpenDisposition::NEW_FOREGROUND_TAB,

extensions::SOURCE_INSTALLED_NOTIFICATION);

OpenApplication(params);

}