chrome/browser/ui/views/download/download_feedback_dialog_view.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/download/download_feedback_dialog_view.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/views/conflicting_module_view_win.cc ('k') | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/download/download_feedback_dialog_view.h"	5 #include "chrome/browser/ui/views/download/download_feedback_dialog_view.h"

6	6

7 #include "base/metrics/histogram.h"	7 #include "base/metrics/histogram.h"

8 #include "base/supports_user_data.h"	8 #include "base/supports_user_data.h"

9 #include "chrome/browser/platform_util.h"	9 #include "chrome/browser/platform_util.h"

10 #include "chrome/browser/profiles/profile.h"	10 #include "chrome/browser/profiles/profile.h"

(...skipping 138 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
149 views::View* DownloadFeedbackDialogView::CreateExtraView() {	149 views::View* DownloadFeedbackDialogView::CreateExtraView() {

150 return link_view_;	150 return link_view_;

151 }	151 }

152	152

153 void DownloadFeedbackDialogView::LinkClicked(	153 void DownloadFeedbackDialogView::LinkClicked(

154 views::Link* source, int event_flags) {	154 views::Link* source, int event_flags) {

155 WindowOpenDisposition disposition =	155 WindowOpenDisposition disposition =

156 ui::DispositionFromEventFlags(event_flags);	156 ui::DispositionFromEventFlags(event_flags);

157 content::OpenURLParams params(	157 content::OpenURLParams params(

158 GURL(l10n_util::GetStringUTF8(IDS_SAFE_BROWSING_PRIVACY_POLICY_URL)),	158 GURL(l10n_util::GetStringUTF8(IDS_SAFE_BROWSING_PRIVACY_POLICY_URL)),

159 content::Referrer(),	159 content::Referrer(), disposition == WindowOpenDisposition::CURRENT_TAB

160 disposition == CURRENT_TAB ? NEW_FOREGROUND_TAB : disposition,	160 ? WindowOpenDisposition::NEW_FOREGROUND_TAB

	161 : disposition,

161 ui::PAGE_TRANSITION_LINK, false);	162 ui::PAGE_TRANSITION_LINK, false);

162 navigator_->OpenURL(params);	163 navigator_->OpenURL(params);

163 }	164 }

OLD	NEW