Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5314)

Unified Diff: chrome/test/base/test_browser_window.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/in_process_browser_test.cc ('k') | chrome/test/base/tracing_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/test_browser_window.cc
diff --git a/chrome/test/base/test_browser_window.cc b/chrome/test/base/test_browser_window.cc
index 10dd131fa1bfbd38a5c6fd33d471a9815f203750..b8181d4d8347cff72fe8d85a7a19c4c6022125b4 100644
--- a/chrome/test/base/test_browser_window.cc
+++ b/chrome/test/base/test_browser_window.cc
@@ -34,7 +34,7 @@ GURL TestBrowserWindow::TestLocationBar::GetDestinationURL() const {
WindowOpenDisposition
TestBrowserWindow::TestLocationBar::GetWindowOpenDisposition() const {
- return CURRENT_TAB;
+ return WindowOpenDisposition::CURRENT_TAB;
}
ui::PageTransition
@@ -170,7 +170,7 @@ DownloadShelf* TestBrowserWindow::GetDownloadShelf() {
WindowOpenDisposition TestBrowserWindow::GetDispositionForPopupBounds(
const gfx::Rect& bounds) {
- return NEW_POPUP;
+ return WindowOpenDisposition::NEW_POPUP;
}
FindBar* TestBrowserWindow::CreateFindBar() {
« no previous file with comments | « chrome/test/base/in_process_browser_test.cc ('k') | chrome/test/base/tracing_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698