Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6984)

Unified Diff: chrome/browser/ui/webui/chrome_web_contents_handler.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_contents_handler.cc
diff --git a/chrome/browser/ui/webui/chrome_web_contents_handler.cc b/chrome/browser/ui/webui/chrome_web_contents_handler.cc
index 4bc2b65f9df96ab8c9ac5d15c0f8f76794867bae..7f5fd4d0858a3cccd175f00e3b5b4740f7238e74 100644
--- a/chrome/browser/ui/webui/chrome_web_contents_handler.cc
+++ b/chrome/browser/ui/webui/chrome_web_contents_handler.cc
@@ -43,10 +43,11 @@ WebContents* ChromeWebContentsHandler::OpenURLFromTab(
browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile));
chrome::NavigateParams nav_params(browser, params.url, params.transition);
nav_params.referrer = params.referrer;
- if (source && source->IsCrashed() && params.disposition == CURRENT_TAB &&
+ if (source && source->IsCrashed() &&
+ params.disposition == WindowOpenDisposition::CURRENT_TAB &&
ui::PageTransitionCoreTypeIs(params.transition,
ui::PAGE_TRANSITION_LINK)) {
- nav_params.disposition = NEW_FOREGROUND_TAB;
+ nav_params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
} else {
nav_params.disposition = params.disposition;
}

Powered by Google App Engine
This is Rietveld 408576698