Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: chrome/browser/ui/app_list/app_list_view_delegate.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_view_delegate.cc
diff --git a/chrome/browser/ui/app_list/app_list_view_delegate.cc b/chrome/browser/ui/app_list/app_list_view_delegate.cc
index 319688808d416718f88fcb9d9f71f694b1299939..272c29a0b5334ab75c9e9d7f57f4237a1b18dd22 100644
--- a/chrome/browser/ui/app_list/app_list_view_delegate.cc
+++ b/chrome/browser/ui/app_list/app_list_view_delegate.cc
@@ -528,9 +528,8 @@ void AppListViewDelegate::OpenHelp() {
chrome::ScopedTabbedBrowserDisplayer displayer(profile_);
content::OpenURLParams params(GURL(chrome::kAppLauncherHelpURL),
content::Referrer(),
- NEW_FOREGROUND_TAB,
- ui::PAGE_TRANSITION_LINK,
- false);
+ WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui::PAGE_TRANSITION_LINK, false);
displayer.browser()->OpenURL(params);
}
@@ -761,7 +760,8 @@ gfx::ImageSkia* AppListViewDelegate::GetAppsIcon() const {
void AppListViewDelegate::OpenLearnMoreLink() {
controller_->OpenURL(profile_, GURL(GetLearnMoreLink()),
- ui::PAGE_TRANSITION_LINK, CURRENT_TAB);
+ ui::PAGE_TRANSITION_LINK,
+ WindowOpenDisposition::CURRENT_TAB);
}
#endif // !defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc ('k') | chrome/browser/ui/app_list/start_page_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698