Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
index b9d163a1b4e030b48003c48cc8e16ae47cf81b4e..49242ccc138a412fadc87458c94f5d89445e9a70 100644
--- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
@@ -145,15 +145,15 @@ void BookmarkContextMenuController::ExecuteCommand(int id, int event_flags) {
case IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW: {
WindowOpenDisposition initial_disposition;
if (id == IDC_BOOKMARK_BAR_OPEN_ALL) {
- initial_disposition = NEW_BACKGROUND_TAB;
+ initial_disposition = WindowOpenDisposition::NEW_BACKGROUND_TAB;
content::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_OpenAll"));
} else if (id == IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW) {
- initial_disposition = NEW_WINDOW;
+ initial_disposition = WindowOpenDisposition::NEW_WINDOW;
content::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_OpenAllInNewWindow"));
} else {
- initial_disposition = OFF_THE_RECORD;
+ initial_disposition = WindowOpenDisposition::OFF_THE_RECORD;
content::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_OpenAllIncognito"));
}

Powered by Google App Engine
This is Rietveld 408576698