chrome/browser/password_manager/password_manager_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc ('k') | chrome/browser/platform_util_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager_browsertest.cc

diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc

index c5d05d396671a933f4421a9fedf0ad733982bf15..6d23c5c03ee38557a94ba9b4a260b87530e4bbff 100644

--- a/chrome/browser/password_manager/password_manager_browsertest.cc

+++ b/chrome/browser/password_manager/password_manager_browsertest.cc

@@ -1290,9 +1290,8 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, NoLastLoadGoodLastLoad) {

// WebContents, but don't wait for navigation, which only finishes after

// authentication.

ui_test_utils::NavigateToURLWithDisposition(

- browser(),

- embedded_test_server()->GetURL("/basic_auth"),

- NEW_FOREGROUND_TAB,

+ browser(), embedded_test_server()->GetURL("/basic_auth"),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);

content::NavigationController* nav_controller =

@@ -2586,8 +2585,8 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,

&WebContents()->GetController();

WindowedAuthNeededObserver auth_needed_observer(nav_controller);

ui_test_utils::NavigateToURLWithDisposition(

- browser(), embedded_test_server()->GetURL("/basic_auth"), CURRENT_TAB,

- ui_test_utils::BROWSER_TEST_NONE);

+ browser(), embedded_test_server()->GetURL("/basic_auth"),

+ WindowOpenDisposition::CURRENT_TAB, ui_test_utils::BROWSER_TEST_NONE);

auth_needed_observer.Wait();

// The auth dialog caused a query to PasswordStore, make sure it was

@@ -2746,13 +2745,15 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,

// browser.

IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, InternalsPage) {

ui_test_utils::NavigateToURLWithDisposition(

- browser(), GURL("chrome://password-manager-internals"), CURRENT_TAB,

+ browser(), GURL("chrome://password-manager-internals"),

+ WindowOpenDisposition::CURRENT_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

content::WebContents* internals_web_contents = WebContents();

ui_test_utils::NavigateToURLWithDisposition(

browser(), embedded_test_server()->GetURL("/password/password_form.html"),

- NEW_FOREGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

std::string find_renderer_logs =

"var text = document.getElementById('log-entries').innerText;"