Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: chrome/browser/metrics/metrics_service_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service_browsertest.cc
diff --git a/chrome/browser/metrics/metrics_service_browsertest.cc b/chrome/browser/metrics/metrics_service_browsertest.cc
index 2ba8c0217db3677a2916457dffb51f717dad7277..2167d5ae714c302f266eaacea391fed3d10a899b 100644
--- a/chrome/browser/metrics/metrics_service_browsertest.cc
+++ b/chrome/browser/metrics/metrics_service_browsertest.cc
@@ -46,17 +46,13 @@ class MetricsServiceBrowserTest : public InProcessBrowserTest {
base::FilePath page1_path = test_directory.AppendASCII("title2.html");
ui_test_utils::NavigateToURLWithDisposition(
- browser(),
- net::FilePathToFileURL(page1_path),
- NEW_FOREGROUND_TAB,
- kBrowserTestFlags);
+ browser(), net::FilePathToFileURL(page1_path),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB, kBrowserTestFlags);
base::FilePath page2_path = test_directory.AppendASCII("iframe.html");
ui_test_utils::NavigateToURLWithDisposition(
- browser(),
- net::FilePathToFileURL(page2_path),
- NEW_FOREGROUND_TAB,
- kBrowserTestFlags);
+ browser(), net::FilePathToFileURL(page2_path),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB, kBrowserTestFlags);
}
};
« no previous file with comments | « chrome/browser/memory/tab_manager_observer_browsertest.cc ('k') | chrome/browser/net/errorpage_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698