chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

index 6d672cbc61da1fd9cad52815826b09fd298d25e2..0f7c7965771bb7618cf051293a815dd5fedfbad0 100644

--- a/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

@@ -49,7 +49,8 @@ using content::Referrer;

Browser* browser = chrome::FindTabbedBrowser(bridge_->profile(), false);

BrowserLiveTabContext* context =

browser ? browser->live_tab_context() : NULL;

- service->RestoreEntryById(context, node->session_id, UNKNOWN);

+ service->RestoreEntryById(context, node->session_id,

+ WindowOpenDisposition::UNKNOWN);

} else {

DCHECK(node->url.is_valid());

WindowOpenDisposition disposition =