chrome/browser/ui/views/accessibility/invert_bubble_view.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/accessibility/invert_bubble_view.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/accessibility/invert_bubble_view.cc

diff --git a/chrome/browser/ui/views/accessibility/invert_bubble_view.cc b/chrome/browser/ui/views/accessibility/invert_bubble_view.cc

index c92e3644fa8688a19dd7da704c1c58aff1687a94..49f4932f626275c05a7e9fa1e94c3064b6b5b70a 100644

--- a/chrome/browser/ui/views/accessibility/invert_bubble_view.cc

+++ b/chrome/browser/ui/views/accessibility/invert_bubble_view.cc

@@ -154,7 +154,9 @@ void InvertBubbleView::OpenLink(const std::string& url, int event_flags) {

ui::DispositionFromEventFlags(event_flags);

content::OpenURLParams params(

GURL(url), content::Referrer(),

- disposition == CURRENT_TAB ? NEW_FOREGROUND_TAB : disposition,

+ disposition == WindowOpenDisposition::CURRENT_TAB

+ ? WindowOpenDisposition::NEW_FOREGROUND_TAB

+ : disposition,

ui::PAGE_TRANSITION_LINK, false);

browser_->OpenURL(params);

}