Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1732)

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/sessions/sessions_api.cc
diff --git a/chrome/browser/extensions/api/sessions/sessions_api.cc b/chrome/browser/extensions/api/sessions/sessions_api.cc
index e308528eb340f1fd29ef3af294ad5273b90d2dd4..35348909a0ff6b08e2e6d2ca9da7ffe35f42dbff 100644
--- a/chrome/browser/extensions/api/sessions/sessions_api.cc
+++ b/chrome/browser/extensions/api/sessions/sessions_api.cc
@@ -472,7 +472,8 @@ bool SessionsRestoreFunction::RestoreLocalSession(const SessionId& session_id,
BrowserLiveTabContext::FindContextForWebContents(
browser->tab_strip_model()->GetActiveWebContents());
std::vector<sessions::LiveTab*> restored_tabs =
- tab_restore_service->RestoreEntryById(context, session_id.id(), UNKNOWN);
+ tab_restore_service->RestoreEntryById(context, session_id.id(),
+ WindowOpenDisposition::UNKNOWN);
// If the ID is invalid, restored_tabs will be empty.
if (restored_tabs.empty()) {
SetInvalidIdError(session_id.ToString());
@@ -514,8 +515,8 @@ bool SessionsRestoreFunction::RestoreForeignSession(const SessionId& session_id,
content::WebContents* contents = tab_strip->GetActiveWebContents();
content::WebContents* tab_contents =
- SessionRestore::RestoreForeignSessionTab(contents, *tab,
- NEW_FOREGROUND_TAB);
+ SessionRestore::RestoreForeignSessionTab(
+ contents, *tab, WindowOpenDisposition::NEW_FOREGROUND_TAB);
SetResultRestoredTab(tab_contents);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698