Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_message_bubble_controller.cc
diff --git a/chrome/browser/extensions/extension_message_bubble_controller.cc b/chrome/browser/extensions/extension_message_bubble_controller.cc
index 616c6f8560127d28b3cdc2c747eabe98bb732a3f..9b933a5155d42889c757887123a248517ffaf372 100644
--- a/chrome/browser/extensions/extension_message_bubble_controller.cc
+++ b/chrome/browser/extensions/extension_message_bubble_controller.cc
@@ -228,12 +228,10 @@ void ExtensionMessageBubbleController::OnLinkClicked() {
// perform our cleanup here before opening the new tab.
OnClose();
if (!g_should_ignore_learn_more_for_testing) {
- browser_->OpenURL(
- content::OpenURLParams(delegate_->GetLearnMoreUrl(),
- content::Referrer(),
- NEW_FOREGROUND_TAB,
- ui::PAGE_TRANSITION_LINK,
- false));
+ browser_->OpenURL(content::OpenURLParams(
+ delegate_->GetLearnMoreUrl(), content::Referrer(),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK,
+ false));
}
// Warning: |this| may be deleted here!
}

Powered by Google App Engine
This is Rietveld 408576698